From: Junio C Hamano Date: Sun, 03 Mar 2019 13:33:43 GMT Subject: Re: none Message-ID: In-Reply-To: <20190303132900.4618-1-rohit.ashiwal265@gmail.com> Rohit Ashiwal writes: > Just to be clear of what caused the error: > 1. Path not being file, or > 2. File not being empty > I am checking for both. test -s makes sure is file; if it is not a file, then it won't yield true. So why do you need to say test_path_is_file yourself, if you are asking "test -s"?