From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 01 Dec 2019 16:33:14 GMT
Subject: Re: [PATCH] t7812: expect failure for grep -i with invalid UTF-8 data
Message-ID: <xmqqo8wsypit.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <87a78ddc9o.fsf@hase.home>

Andreas Schwab <schwab@linux-m68k.org> writes:

> On Nov 29 2019, Todd Zullinger wrote:
>
>> When the 'grep with invalid UTF-8 data' tests were added/adjusted in
>> 8a5999838e (grep: stess test PCRE v2 on invalid UTF-8 data, 2019-07-26)
>> and 870eea8166 (grep: do not enter PCRE2_UTF mode on fixed matching,
>> 2019-07-26) they lacked a redirect which caused them to falsely succeed
>> on most architectures.  They failed on big-endian arches where the test
>> never reached the portion which was missing the redirect.
>
> It's not about big vs little endian, it's only about JIT vs non-JIT.

So, which one of JIT / non-JIT sides did the test fail unexpectedly?

Should I do s/on big-endian arches/with PCRE with JIT disabled/
while queuing the patch?

Thanks.