From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 15 Apr 2020 15:48:00 GMT
Subject: Re: [PATCH v12 3/7] receive-pack: add new proc-receive hook
Message-ID: <xmqqo8rs7ntb.fsf@gitster.c.googlers.com>
In-Reply-To: <20200414123257.27449-4-worldhello.net@gmail.com>

Jiang Xin <worldhello.net@gmail.com> writes:

> diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
> index 2cc18bbffd..fbbb01135e 100644
> --- a/builtin/receive-pack.c
> +++ b/builtin/receive-pack.c
> @@ -13,6 +13,7 @@
>  #include "remote.h"
>  #include "connect.h"
>  #include "string-list.h"
> +#include "string.h"
>  #include "sha1-array.h"
>  #include "connected.h"
>  #include "argv-array.h"

What are you using from the system <string.h>, that is not covered
by existing inclusion of "git-compat-util.h"?  

Don't include any system header directly in our *.c code (unless it
is a platform-specific compat/ thing).