From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 24 Jul 2020 00:05:18 GMT
Subject: Re: [PATCH v3 34/39] t: add test_oid option to select hash algorithm
Message-ID: <xmqqo8o5ok01.fsf@gitster.c.googlers.com>
In-Reply-To: <CAPig+cQPfAD8Jcm2WC4XCE+tFqQsV5e0yAtN0_Txb5ro1Rhifg@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

> On Thu, Jul 23, 2020 at 7:39 PM brian m. carlson
> <sandals@crustytoothpaste.net> wrote:
>> On 2020-07-23 at 04:51:32, Eric Sunshine wrote:
>> > On Wed, Jul 22, 2020 at 9:11 PM brian m. carlson
>> > <sandals@crustytoothpaste.net> wrote:
>> > > +               --hash=*)
>> > > +                       algo="${1#--hash=}" &&
>> >
>> > Bikeshedding: I wonder if this should be named "--algo"?
>>
>> We already have a use of this in t5515; I appear to have accidentally
>> sent it in an earlier series.  I can, of course, change it, but I don't
>> feel strongly that one or the other is better.  If you do feel strongly,
>> or you think it's confusing, I'm happy to change it.
>
> I don't feel strongly about it and wouldn't insist that it be changed.

I am in favor of "algo", but let's leave the patch noise outside the
series.  It is something we can do after the dust settles.

And when such a clean-up comes, I'll try to remember pointing out
the case/arms)/esac indentation rule ;-)

Thanks.