From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 19 Aug 2020 22:20:21 GMT
Subject: Re: [PATCH v8 4/5] rebase -i: support --ignore-date
Message-ID: <xmqqo8n6s2fu.fsf@gitster.c.googlers.com>
In-Reply-To: <88535175-0540-c96d-24b5-c4d407422a8c@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

>> +# Checking for +0000 in the author date is sufficient since the
>> +# default timezone is UTC but the timezone used while committing is
>> +# +0530. The inverted logic in the grep is necessary to check all the
>> +# author dates in the file.
>> +test_ctime_is_ignored () {
>> +	git log $1 --format=%ai >authortime &&
>> +	! grep -v +0000 authortime
>> +}
>
>
> I don't know what I was thinking when I wrote that - it should be called
> test_atime_is_ignored() as it's testing the author date

Will tweak locally.  No need to resend.

Thanks.