From: Junio C Hamano Date: Wed, 21 Oct 2020 21:24:22 GMT Subject: Re: [PATCH 1/2] fsmonitor: stop inline'ing mark_fsmonitor_valid / _invalid Message-ID: In-Reply-To: <20201021205537.GB1270359@nand.local> Taylor Blau writes: >> +extern void mark_fsmonitor_invalid(struct index_state *istate, struct cache_entry *ce); > ... > Any reason that these need to be externed explicitly? Note that these > functions are already externed by default since you haven't said > otherwise (and for no other reason than this'd be the only explicitly > externed function in fsmonitor.h). Possibly due to the recent discussion? https://lore.kernel.org/git/xmqqtuv3ryhr.fsf_-_@gitster.c.googlers.com/