From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 09 Jan 2021 22:42:56 GMT
Subject: Re: Is t5516 somehow flakey only on macOS?
Message-ID: <xmqqo8hxenpr.fsf@gitster.c.googlers.com>
In-Reply-To: <20210109173336.GS8396@szeder.dev>

SZEDER Gábor <szeder.dev@gmail.com> writes:

>> Commit 014ade7484 (upload-pack: send ERR packet for non-tip objects,
>> 2019-04-13) added a test that greps the output of a failed fetch to make
>> sure that upload-pack sent us the ERR packet we expected. But checking
>> this is racy; despite the argument in that commit, the client may still
>> be sending a "done" line when the server exits, causing it to die() on a
>
> Nit: I think using the word "after" would make the problematic
> sequence of events a tad clearer, i.e. "... after the server has
> exited, ...".

Thanks everybody for helping with extra clarity.  I do find it
easier to follow with "after the server has exited" to picture
the sequence of events in my mind.