From: Junio C Hamano Date: Wed, 17 Mar 2021 18:48:07 GMT Subject: Re: [PATCH v4 11/22] fsck.h: move FSCK_{FATAL,INFO,ERROR,WARN,IGNORE} into an enum Message-ID: In-Reply-To: <20210316161738.30254-12-avarab@gmail.com> Ævar Arnfjörð Bjarmason writes: > Move the FSCK_{FATAL,INFO,ERROR,WARN,IGNORE} defines into a new > fsck_msg_type enum. Nice. > Untangling that would take some more work, since we expose the new > "enum fsck_msg_type" to both. Similar to "enum object_type" it's not > worth structuring the API in such a way that only those who need > FSCK_{ERROR,WARN} pass around a different type.