From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 01 Jul 2021 20:11:20 GMT
Subject: Re: [PATCH 14/15] [GSOC] cat-file: re-implement --textconv, --filters options
Message-ID: <xmqqo8blrdzr.fsf@gitster.g>
In-Reply-To: <3aeb4d3d3ec9dc112a19a8b4adeaf213577b4028.1625155693.git.gitgitgadget@gmail.com>

"ZheNing Hu via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: ZheNing Hu <adlternative@gmail.com>
>
> After cat-file reuses the ref-filter logic, we re-implement the
> functions of --textconv and --filters options.
>
> Add members `use_textconv` and `use_filters` in struct `ref_format`,
> and use global variables `use_filters` and `use_textconv` in
> `ref-filter.c`, so that we can filter the content of the object
> in get_object().

These global variables are problematic.  The places that check them
are quite isolated, and it makes me wonder why we cannot pass a
format instance through the callchain down to get_object().