From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 12 Feb 2024 22:51:04 GMT
Subject: Re: [RFC PATCH v2 3/6] test-tool run-command testsuite: remove hardcoded filter
Message-ID: <xmqqo7cl47qf.fsf@gitster.g>
In-Reply-To: <ZcqgMgFx97DbH94y@google.com>

Josh Steadmon <steadmon@google.com> writes:

>> As we discussed in Peff's Makefile change that enumerates "which are
>> the unit-test programs?" Generally, $(wildcard) and readdir() to
>> slurp everything in a directory, including stuff that is an
>> untracked cruft, is not an excellent idea.
>> 
>> This is not an end-user facing program and we are in full control of
>> its input (most notably, "which ones should we be running?"), I do
>> not think it would be a huge issue, though.
>
> Would you prefer if I remove the default behavior of "run everything in
> the CWD" and require passing in at least one filename filter?

No preference either way at all.