From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 19 Mar 2024 21:00:34 GMT
Subject: Re: [PATCH v3 1/2] t: add a test helper for getting hostname
Message-ID: <xmqqo7balyx9.fsf@gitster.g>
In-Reply-To: <20240319205753.GB1159535@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> I think you need to lose the exit status. Or alternatively do:
>
>   hostname=$(test-tool xgethostname || echo unknown)
>
> See my other reply.

As "test-tool xgethostname" runs exactly the same codepath as
"includeIf hostname:blah" feature, I would actually prefer for a
failing "test-tool gethostname" to _break_ this test so that people
can take notice.