From: Junio C Hamano Date: Mon, 24 Mar 2025 15:42:54 GMT Subject: Re: [PATCH v2 2/5] libgit-sys: add symlink to git repo root and build out of tree Message-ID: In-Reply-To: Eric Sunshine writes: > On Fri, Mar 21, 2025 at 6:14 PM Josh Steadmon wrote: >> Unlike `cargo build`, `cargo package` does not get access to the entire Git repo >> containing a Rust crate. Instead, it prepares a directory starting from the >> crate root (potentially excluding files, such as those not under version >> control, or explicity excluded in the Cargo.toml file). > > s/explicity/explicitly/ > >> diff --git a/contrib/libgit-sys/git-src b/contrib/libgit-sys/git-src >> @@ -0,0 +1 @@ >> +../.. >> \ No newline at end of file > > Meh. https://github.com/git/git/actions/runs/14030831429/job/39278185588#step:3:1 All of the Windows test jobs (not build ones) are broken due to the presence of ../.. symbolic link. Is that ugly hack the only way we can make this work?