From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 15 Apr 2025 19:48:53 GMT
Subject: Re: [PATCH v2 1/8] pack-objects: use standard option incompatibility functions
Message-ID: <xmqqo6wxkxy2.fsf@gitster.g>
In-Reply-To: <Z/60anmKVxke0AVX@nand.local>

Taylor Blau <me@ttaylorr.com> writes:

> Now I can't un-see it ;-). Even though it's not a correctness issue as
> you note, the whole thing leaves a bad taste in my mouth. I'll swap the
> ordering to match the original in the next round.

I do not think we can be completely faithful to the original in this
rewrite, simply because the original is not consistent with what
die_for_incompat() thing produces and you'd need to adjust the test
anyway.  So unless there are other things you need to reroll, I
wouldn't worry about it too much.

Thanks.