From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 09 Feb 2026 17:05:30 GMT
Subject: Re: [PATCH 0/4] trace2: add macOS and Windows process ancestry tracing
Message-ID: <xmqqo6lx6e5h.fsf@gitster.g>
In-Reply-To: <56c1a7eb-a645-4453-8024-b320c1ebd55e@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

>> Furthermore, let's refactor the Windows implementation to align with the
>> Linux and macOS versions - by emitting the ancestry information as a
>> cmd_ancestry event. We keep the older, custom data_json event type on
>> Windows for compatibility for consumers of the TRACE2 data that use the
>> older event.
>
> I appreciate this compatibility approach. I mention in my patch-by-patch
> review that we should eventually drop the old mechanism, say in two major
> versions.
>
> The code looks good to me, just a question about the testing and some very
> minor nitpicks around recursion and strvecs.

Thanks for a prompt review (and thanks for the series author for
writing the patches, of course).

Will mark as "expecting a hopefully minor and final reroll".