From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 24 Feb 2026 20:25:26 GMT
Subject: Re: [PATCH v2 1/2] format-patch: add ability to use alt cover format
Message-ID: <xmqqo6ldga89.fsf@gitster.g>
In-Reply-To: <66cac565f8a40f8de3dc3d857feb681bb80cb136.1771925291.git.mroik@delayed.space>

Mirko Faina <mroik@delayed.space> writes:

> +	char *cover_letter_fmt = NULL;
> ...
> +
> +	if (cover_letter && !cover_letter_fmt)
> +		cover_letter_fmt = "shortlog";

The compiler flags the above assignment, which is understandable.

builtin/log.c:2442:34: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
 2442 |                 cover_letter_fmt = "shortlog";