From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 10 Apr 2026 16:01:16 GMT
Subject: Re: [GSoC PATCH v4 2/5] pack-write: add helper to fill promisor file after repack
Message-ID: <xmqqo6jqpzxv.fsf@gitster.g>
In-Reply-To: <34c4e793113f22c393a6196d6e99a96d78cc3ab9.1775832056.git.lorenzo.pegorari2002@gmail.com>

LorenzoPegorari <lorenzo.pegorari2002@gmail.com> writes:

> +			/* If <time> doesn't exist, retrieve it and add it to line */
> +			if (line_sections.nr < 3)
> +				strbuf_addf(&line, " %lld", (long long int)source_stat.st_mtim.tv_sec);

It should be easy to see in the output of

	$ git grep -e '%lld' -e 'st_mtim\.tv_sec'

that we do not use these constructs.

Write it like this instead

				strbuf_addf(&line, " %" PRItime,
					    (timestamp_t)source_stat.st_mtime);

examples to mimick the uses of timestamp_t and PRItime are found in
many places; worktree.c, date.c, builtin/blame.c would give plenty.