From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 14 Jun 2026 04:05:33 GMT
Subject: Re: [PATCH v5 2/2] graph: indent visual root in graph
Message-ID: <xmqqo6hdepgy.fsf@gitster.g>
In-Reply-To: <20260613-ps-pre-commit-indent-v5-2-8d308efea63d@gmail.com>

Pablo Sabater <pabloosabaterr@gmail.com> writes:

[jc: Taylor CC'ed for his expertise and opinion on the quoted part
that mucks with commit-graph files during the test]

> diff --git a/t/t4218-log-graph-indentation.sh b/t/t4218-log-graph-indentation.sh
> new file mode 100755
> index 0000000000..ccf15c0a52
> --- /dev/null
> +++ b/t/t4218-log-graph-indentation.sh
> @@ -0,0 +1,467 @@
> +#!/bin/sh
> ...
> +# disable commit-graph topo order to have the graph to render in different
> +# ways (used in --first-parent tests to have multiple visual roots while a
> +# column is active at the same time).
> +unset_commit_graph() {
> +	sane_unset GIT_TEST_COMMIT_GRAPH &&
> +	rm -f .git/objects/info/commit-graph &&
> +	rm -rf .git/objects/info/commit-graphs
> +}

I do not quite understand why having commit-graph makes the test
result unpredictable here, but wouldn't we have a more stable way
to disable use of commit-graph than going into filesystem and muck
with the implementation detail like the above?  

Thanks.