From: Junio C Hamano Date: Wed, 28 Oct 2026 16:26:34 GMT Subject: Re: [PATCH] refs: fix loose-ref seeking across directory boundaries Message-ID: In-Reply-To: Patrick Steinhardt writes: > On Tue, Oct 27, 2026 at 03:22:48PM -0700, Junio C Hamano wrote: >> "Venkat Ragavan via GitGitGadget" writes: >> >> > From: Venkat Ragavan S >> > >> > When seeking through loose refs, cache_ref_iterator_seek() compares >> > each directory component without its trailing slash. This can confuse >> > a directory with a similarly named ref that sorts before it. >> > ... >> > Add regression tests for shared-prefix names, missing nested markers, >> > and markers beyond the end of the ref listing, using loose, packed, >> > and mixed refs. >> > >> > Signed-off-by: Venkat Ragavan S >> > --- >> > refs: fix loose-ref seeking across directory boundaries >> >> I overlooked this topic, but re-reading the discussion, aside from a >> test that confused a reader, it seems the topic was already ready to >> go? >> >> Any objections to the idea of making the topic ready for 'next'? > > Sorry, I lost track of this patch series, but I've reviewed it now. > Overall this looks good, but I wonder whether this really should be > split up into three patches because as far as I understand, this single > patch solves three separate bugs at once. > > Patrick Thanks. Let's hear from the author, then.