From: Junio C Hamano Date: Mon, 02 Nov 2026 08:51:20 GMT Subject: Re: [PATCH v2 0/5] format-rev: add --abbrev, --color, and --date Message-ID: In-Reply-To: Junio C Hamano writes: > kristofferhaugsbakk@fastmail.com writes: > >> From: Kristoffer Haugsbakk >> >> Topic name (applied): kh/format-rev-more-options >> >> Topic summary: Add three more options for controlling the formatting. Also >> do some minor refactoring and text fixes as preparatory steps. >> >> § Changes in v2 >> >> See the patch notes for details. >> >> • Use designated initializer syntax. That’s more readable since you pair >> the field with the value and you can omit zero-value fields. >> >> https://lore.kernel.org/git/xmqqfr0hswxm.fsf@gitster.g/ >> • Fix useless `BUG` placements https://lore.kernel.org/git/xmqqfr0hswxm.fsf@gitster.g/ >> • Add preliminary patch “place BUG calls first in callback” for existing >> `BUG` statement placement >> • Based on the previous point >> • Patch “learn --abbrev, --color, and --date”: test a few more options > > Nobody is interested in reviewing these patches? They looked more > or less OKish to me, but I am not the best person to review this > series, as I do not see much point in this experimental command. > It would be nice to see reviews from those who are more invested > in seeing the command work better than I am. Second call. Anybody? Unless we see some volunteers to give it a review in a few weeks, I will discard the topic out of my tree, as 'seen' has been crowded with topics that have been collecting dust without getting many reviews. Thanks.