From: Junio C Hamano Date: Wed, 11 Nov 2026 16:44:42 GMT Subject: Re: [PATCH v5 0/5] log: speed up --follow following renames for non-linear history Message-ID: In-Reply-To: Justin Tobler writes: > Summary > git log --stat --follow -- include/linux/rsc_table.h (rev = 304812ed33 reverted) ran > 14.30 ± 0.44 times faster than git log --stat --follow -- include/linux/rsc_table.h (rev = 304812ed33) > 1.65 ± 0.05 times faster than git log --stat --follow -- include/linux/rsc_table.h (rev = v5) > ... > While the original patch and this series do improve correctness of > following a file through history, I wonder if the increased cost is > ultimately worth it in most scenarios. Maybe this could be something > opt-in with another flag instead of toggled on my default? > > With this in mind, maybe it would be worth it to revert 304812ed33de > (log: improve --follow following renames for non-linear history, > 2026-06-22) and restart with a fresh series. IMO, it might make the > changes here a bit easier to validate also. This sounds sensible, and is far better than reverting and declaring "The original 'checkbox hack' should stay here forever because doing it right will be very expensive". Giving it a fresh start would be valuable as following a single the is an important operation in some workflows. Thanks.