From: Junio C Hamano Date: Wed, 07 May 2014 20:40:05 GMT Subject: Re: [PATCH] Windows: Always normalize paths to Windows-style Message-ID: In-Reply-To: <20140507184444.GB4013@sandbox-ub> Heiko Voigt writes: > On Mon, Apr 28, 2014 at 04:29:31PM +0200, Stepan Kasal wrote: >> this is another patch that lives in msysGit for a long time. >> Originally, it had two parts: >> (Cf https://github.com/msysgit/git/commit/64a8a03 ) >> >> 1) adding alias pwd='pwd -W' to git-sh-setup.sh >> This one went upstream, though as a shell function. >> >> 2) revert of commit 4dce7d9b by Johannes Sixt >> This mingw-specific commit was created less than 3 weeks before >> it was reverted. And it stayed reverted for two years. >> >> Could you please either accept this patch, or revert 4dce7d9b ? >> (Both alternatives are exactly the same.) > > Sorry for the late reply. To me reverting (or omitting at the next > rebasing merge) this patch sound fine, as it seems to be superseeded by > the upstream change. > > As I can see thats already done on master, so it seems to be all good. Are you guys talking about be39048a (git-sh-setup.sh: Add an pwd() function for MinGW, 2012-04-17) which has been in since v1.7.11? The change introduced by 4dce7d9b (submodules: fix ambiguous absolute paths under Windows, 2012-03-04) still exists, but your "reverting this patch sound fine" confuses me.