From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 03 Jun 2015 21:20:14 GMT
Subject: Re: [PATCH v3 4/4] read_loose_refs(): treat NULL_SHA1 loose references as broken
Message-ID: <xmqqmw0gwktt.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20150603201511.GA31157@peff.net>

Jeff King <peff@peff.net> writes:

> On Wed, Jun 03, 2015 at 11:51:43AM -0700, Junio C Hamano wrote:
>
>> Jeff King <peff@peff.net> writes:
>> 
>> > On Wed, Jun 03, 2015 at 03:51:59PM +0200, Michael Haggerty wrote:
>> >
>> >> NULL_SHA1 is used to indicate of "invalid SHA-1" throughout our code
>> >
>> > s/of/an/ ?
>> 
>> Also possibly s/invalid SHA-1/invalid ref/?
>
> I thought it was trying to express that we use the null sha1 as a
> sentinel value throughout the code, no matter if the value came from a
> ref or otherwise.

Yeah, an invalid object name, not limited to refs, is correct.

Thanks.