From: Junio C Hamano Date: Mon, 14 Sep 2015 22:06:22 GMT Subject: Re: [PATCHv2] fetch submodules in parallel Message-ID: In-Reply-To: <1442267451-2527-1-git-send-email-sbeller@google.com> Stefan Beller writes: > This replaces the last patch of the "Parallel git submodule fetching" > series. Changes: > > * have correct return code in submodule fetching when one submodule fails > * use poll instead of select now > * broke down into more smaller functions instead of one giant. > (I think it is an improvement, but I wouldn't be surprised if someone objects) > * closed memory leaks > * document the need for stdout_to_stderr > > I don't deem it RFC-ish any more but good to go. I didn't say this in the previous round because it smelled like an RFC, but for a real submission, 2/2 may be doing too many things at once. I suspect this is more or less "taste" thing, so I won't mind too much as long as the reviewers are OK with it.