From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 13 Jan 2016 00:19:22 GMT
Subject: Re: [PATCH v2 13/21] refs: resolve symbolic refs first
Message-ID: <xmqqmvsaqqk5.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1452561740-8668-14-git-send-email-dturner@twopensource.com>

David Turner <dturner@twopensource.com> writes:

> +static int dereference_symrefs(struct ref_transaction *transaction,
> +			       struct strbuf *err)
> +{
> +	int i;
> +	int nr = transaction->nr;
> +
> +	for (i = 0; i < nr; i++) {
> +		struct ref_update *update = transaction->updates[i];
> +		const char *resolved;
> +		unsigned char sha1[20];
> +		int resolve_flags = 0;
> +		int mustexist = (update->old_sha1 &&
> +				 !is_null_sha1(update->old_sha1));
> +		int deleting = (update->flags & REF_HAVE_NEW) &&
> +			is_null_sha1(update->new_sha1);
> +		struct ref_update *new_update;

This variable is never used (at least at the end of the series after
applying up to 21/21).