From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 22 Feb 2016 18:37:59 GMT
Subject: Re: [PATCH v6 4/4] config: add '--show-origin' option to print the origin of a config value
Message-ID: <xmqqmvqs7fqw.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160222175843.GA4587@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Mon, Feb 22, 2016 at 09:43:25AM -0800, Junio C Hamano wrote:
>
>> larsxschneider@gmail.com writes:
>> 
>> > +test_expect_success '--show-origin with --list' '
>> > +	cat >expect <<-EOF &&
>> > +		file:$HOME/.gitconfig	user.global=true
>> > +		file:$HOME/.gitconfig	user.override=global
>> > +		file:$HOME/.gitconfig	include.path=$INCLUDE_DIR/absolute.include
>> > +		file:$INCLUDE_DIR/absolute.include	user.absolute=include
>> > +		file:.git/config	user.local=true
>> > +		file:.git/config	user.override=local
>> > +		file:.git/config	include.path=../include/relative.include
>> > +		file:.git/../include/relative.include	user.relative=include
>> > +		cmdline:	user.cmdline=true
>> > +	EOF
>> > ...
>> > +test_expect_success '--show-origin stdin' '
>> > +	cat >expect <<-\EOF &&
>> > +		stdin:	user.custom=true
>> > +	EOF
>> 
>> I do recall there was some bikeshedding^Wdesigning discussion, in
>> which I chose not to participate, on the output format, how
>> origin-type and origin-value are given in the output in an
>> unambiguous way that is easy to understand by the end users.
>> 
>> Does the above reflect the concensus from the discussion?  Just
>> double checking.
>
> Yes, I think so.

OK, thanks.