From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 22 Jun 2016 23:12:52 GMT
Subject: Re: [PATCH] pathspec: warn on empty strings as pathspec
Message-ID: <xmqqmvmckebv.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160622230024.24034-1-emilyxxie@gmail.com>

Emily Xie <emilyxxie@gmail.com> writes:

> The fix for this issue requires a two-step approach. As
> there may be existing scripts that knowingly use empty
> strings in this manner, the first step simply invokes a
> warning that (1) declares using empty strings to
> match all paths will become invalid and (2) asks the user
> to use "." if their intent was to match all.
>
> For step two, a follow-up patch several release cycles
> later will remove the warnings and throw an error instead.
>
> This patch is the first step.
>
> Signed-off-by: Emily Xie <emilyxxie@gmail.com>
> Reported-by: David Turner <novalis@novalis.org>
> Mentored-by: Michail Denchev <mdenchev@gmail.com>
> Thanks-to: Sarah Sharp <sarah@thesharps.us> and James Sharp <jamey@minilop.net>
> ---

Looks sensible.  I personally do not think warn-only-once matters in
practice, but now you have implemented it, it is an additional nice
touch ;-)

Will queue.

Thanks.