From: Junio C Hamano Date: Wed, 06 Sep 2017 19:51:19 GMT Subject: Re: [PATCH 34/34] wt-status: release strbuf after use in wt_longstatus_print_tracking() Message-ID: In-Reply-To: <20170830182018.21390-1-l.s.r@web.de> Rene Scharfe writes: > If format_tracking_info() returns 0 only if it didn't touch its strbuf > parameter, so it's OK to exit early in that case. Clean up sb in the > other case. These two "if"s confuse me; perhaps the first one is not needed?