From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 27 Jul 2018 19:29:39 GMT
Subject: Re: [PATCH v3 03/10] config doc: unify the description of fsck.* and receive.fsck.*
Message-ID: <xmqqmuucmq8s.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180727143720.14948-4-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> The documentation for the fsck.<msg-id> and receive.fsck.<msg-id>
> variables was mostly duplicated in two places, with fsck.<msg-id>
> making no mention of the corresponding receive.fsck.<msg-id>, and the
> same for fsck.skipList.

Overall the result reads a lot easily.   Especially this part:

> +	During fsck git may find issues with legacy data which
> +	wouldn't be generated by current versions of git, and which
> +	wouldn't be sent over the wire if `transfer.fsckObjects` was
> +	set. This feature is intended to support working with legacy
> +	repositories containing such data.

that adds only a few sentences and clarifies the impact of
"legacy"-ness to this issue rather nicely.

I first found it a bit odd that fsck.* and receive.fsck.* are
discussed with an apparent asymmetry but it actually is correct,
because we haven't introduced fetch.fsck.* at this step in the
series.

Thanks.