From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 17 Jul 2019 20:10:35 GMT
Subject: Re: [PATCH] range-diff: fix some 'hdr-check' and sparse warnings
Message-ID: <xmqqmuhczakk.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190717192121.GA5447@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Other than that, our options seem to be:
>
>   1. Live with it. IIRC we're already not sparse-clean, and Ramsay
>      mostly looks at the diff to find new problems.

OK.

>   2. Pass -Wno-non-pointer-null to sparse. Unfortunately that also
>      disables more useful warnings (like passing "0" instead of NULL to
>      a function).

Non starter, I am afraind.  The loss outweighs.

>   3. Switch to NULL here, and adhere to that going forward.

This does not sound too bad.