From: Junio C Hamano Date: Mon, 29 Jul 2019 04:54:00 GMT Subject: Re: [PATCH v2 0/5] system header cleanup Message-ID: In-Reply-To: <20190728221904.GA21379@sigill.intra.peff.net> Jeff King writes: > On Sun, Jul 28, 2019 at 01:07:19PM -0700, Carlo Marcelo Arenas Belón wrote: > >> This series is a reroll of jk/no-system-includes-in-dot-c with >> cb/xdiff-no-system-includes-in-dot-c applied on top with minor >> fixes for the commit message based on feedback from Johannes >> and the example put forward by Peff with his own patches. >> >> The changes proposed shouldn't affect any systems (except for >> the 3rd one) and that has since shown to also be needed >> in Alpine Linux (because of _XOPEN_SOURCE redefinition). >> >> The last 2 patches are new to the series and just cleanup >> the dependency list in xdiff. > > Thanks, these all look good to me. Thanks, both. They look good to me too.