From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 05 Feb 2020 20:06:46 GMT
Subject: Re: [PATCH v5 08/15] bugreport: include user interactive shell
Message-ID: <xmqqmu9w6bop.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAN0heSq9AdF_WPmSkxDA3cPzOQBAbuw4oa+8azvLtjbP-jQfKw@mail.gmail.com>

Martin Ågren <martin.agren@gmail.com> writes:

> On Fri, 24 Jan 2020 at 04:41, <emilyshaffer@google.com> wrote:
>> +       char *shell = NULL;
>
> (Unnecessary initialization.)
>
>> +       shell = getenv("SHELL");
>> +       strbuf_addf(sys_info, "$SHELL (typically, interactive shell): %s\n",
>> +                   shell ? shell : "(NULL)");
>
> Thanks for avoiding a classic pitfall. :-)
>
> "<unused>" instead of "(NULL)"? "NULL" is mostly an implementation
> detail.

Isn't that <unset>?