From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 07 Jul 2020 16:43:38 GMT
Subject: Re: [PATCH v9] Support auto-merge for meld to follow the vim-diff behavior
Message-ID: <xmqqmu4b5l8l.fsf@gitster.c.googlers.com>
In-Reply-To: <31ab701d65428$b7ca6cd0$275f4670$@zoom.us>

<lin.sun@zoom.us> writes:

> So in [PATH v10], it still try get the string value first, then detecting the ""(empty)/true/false/auto. 

You cannot interpret an empty output from "git config section.variable";
it could be "[section] variable" (which is true), or it could be a sign
that there is no "[section] variable = value" in the configuration (which
you treat as false).

Catching common spellings of 'true' and 'false' in the output of the
string version of "git config", while checking for 'auto' at the
same time, may not be too bad as an optimization to save an extra
call to "git config --bool 2>/dev/null" (and ignoring errors), so I
am OK with that as long as you leave the empty output alone.