From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 20 Feb 2021 03:31:04 GMT
Subject: Re: [PATCH 0/4] Check .gitmodules when using packfile URIs
Message-ID: <xmqqmtvza007.fsf@gitster.g>
In-Reply-To: <20210219004612.1181920-1-jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

>> This seems to have been stalled but I think it would be a better
>> approach to use a custom callback for error reporting, suggested by
>> Ævar, which would be where his fsck API clean-up topic would lead
>> to.
>> 
>> If it is not ultra-urgent, perhaps you can retract the ones that are
>> queued right now, work with Ævar to finish the error-callback work
>> and rebuild this topic on top of it?  Thanks.
>
> OK - that works. My original idea was to rewrite it using an
> error-callback but using starts_with() instead of the ID that Ævar's
> work will provide, but seeing that at least one other contributor (Peff)
> seems OK with the patches, rebasing mine on top of his works too. I'll
> also take a look at his patches.

Thanks, either way would work for me, but if the suggested route
forces you review Ævar's code and work together, that would be a
good bonus point ;-)