From: Junio C Hamano Date: Tue, 30 Nov 2021 06:32:42 GMT Subject: Re: [PATCH v4 1/4] sparse index: enable only for git repos Message-ID: In-Reply-To: <6db27c92-6ea6-fa5f-8aa7-e1fef7d5ff5a@gmail.com> Lessley Dennington writes: > This is cool! I applied it locally, and it seems to be working well. I > will plan to replace my changes to checkout and pack-objects with this > for v5. I didn't write it to replace the changes you were preparing, though. What the patch is meant to solve is that "git checkout -h" in a repository, whose .git/config has some custom configuration variables that affect how the short help text is shown, were ignoring that per-repository settings by not even checking if we are in a repository at all. When "-h" is in effect, and if you are outside a repository, this would cause the setup_git_directory_gently() function to be called, and we'd reach checkout_main() without having discovered repository. I do not think it removes the need for your "only when startup-info says we have repository, do these" safety. At least, I didn't write the patch to remove that need.