From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 01 Feb 2022 22:20:52 GMT
Subject: Re: [PATCH v8 2/6] branch: make create_branch() always create a branch
Message-ID: <xmqqmtjab54r.fsf@gitster.g>
In-Reply-To: <20220129000446.99261-3-chooglen@google.com>

Glen Choo <chooglen@google.com> writes:

> With the previous commit, there are no more invocations of
> create_branch() that do not create a branch because:
>
> * BRANCH_TRACK_OVERRIDE is no longer passed
> * clobber_head_ok = true and force = false is never passed
>
> Assert these situations, delete dead code and ensure that we're handling
> clobber_head_ok and force correctly by introducing tests for `git branch
> --force`. As a result, create_branch() now always creates a branch.

A very nice simplifiation of semantics.