From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 04 Feb 2022 23:03:15 GMT
Subject: Re: [PATCH v10 3/9] grep tests: add missing "grep.patternType" config tests
Message-ID: <xmqqmtj6jkuk.fsf@gitster.g>
In-Reply-To: <patch-v10-3.9-3464c76cfd7-20220204T211534Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> +	test_expect_success "grep $L with grep.extendedRegexp and grep.patternType are both last-one-wins independently (BRE)" '
> +		echo "${HC}ab:a+bc" >expected &&
> +		git \
> +			-c grep.patternType=default \
> +			-c grep.extendedRegexp=true \
> +			-c grep.patternType=basic \
> +			grep "a+b*c" $H ab >actual &&
> +		test_cmp expected actual
> +	'
> +	test_expect_success "grep $L with grep.patternType=extended and grep.patternType=default" '

Mising blank line between tests.

Other than that, this step looks good.

No need to resend; I'll fix this part up locally again.

Thanks.