From: Junio C Hamano Date: Fri, 16 Dec 2022 23:52:46 GMT Subject: Re: [PATCH v3] git: edit variable types to match what is assigned to them Message-ID: In-Reply-To: "Rose via GitGitGadget" writes: > From: Seija Kijin > > There are many places where "int len = strlen(foo);" is written, > just for len to be passed as a parameter of size_t. True. > This causes truncation and then expansion > back from int to size_t. > > Not to mention, this is poor logic, > and needless truncations can add > extra unneeded instructions. I'd omit the last paragraph if I were writing it, as these two paragraphs saying exactly the same thing.