From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 10 Jun 2024 16:33:43 GMT
Subject: Re: [PATCH v3 1/3] t4020: test exit code with external diffs
Message-ID: <xmqqmsns4v14.fsf@gitster.g>
In-Reply-To: <79a951f8-cf35-4159-a90e-f95d69773413@web.de>

René Scharfe <l.s.r@web.de> writes:

> +check_external_diff () {
> +	expect_code=$1
> +	expect_out=$2
> +	expect_err=$3
> +	command_code=$4
> +	shift 4
> +	options="$@"

Tiny nit, but I'd prefer to see "$@" reserved for its magic and all
other times where it is equivalent to "$*", see the latter used.

Other than that, all three patches looked good to me.  Thanks.