From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 08 May 2025 21:55:31 GMT
Subject: Re: [PATCH 4/5] meson.build: correct setting of GIT_EXEC_PATH
Message-ID: <xmqqmsbm4vjg.fsf@gitster.g>
In-Reply-To: <20250508164443.1506440-5-ramsay@ramsayjones.plus.com>

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

>  if get_option('runtime_prefix')
>    libgit_c_args += '-DRUNTIME_PREFIX'
>    build_options_config.set('RUNTIME_PREFIX', 'true')
> -  git_exec_path = get_option('libexecdir') / 'git-core'
> +
> +  if git_exec_path.startswith('/')
> +    error('runtime_prefix requires a relative libexecdir not:', libexec)
> +  endif

Certainly nice to see these settings taught to be more careful.

Thanks.