From: Junio C Hamano Date: Wed, 08 Jul 2026 01:26:02 GMT Subject: Re: [PATCH v3 2/4] parse-options: add a separate case for help output on error Message-ID: In-Reply-To: <20260708001557.3581080-3-sandals@crustytoothpaste.net> "brian m. carlson" writes: > @@ -1363,7 +1368,7 @@ static enum parse_opt_result usage_with_options_internal(struct parse_opt_ctx_t > parse_options_check_harder(opts); > > if (!usagestr) > - return PARSE_OPT_HELP; > + return err ? PARSE_OPT_HELP_ERROR : PARSE_OPT_HELP; This part, IIUC, got updated from the previous round. Looks sensible. > @@ -1476,7 +1481,7 @@ static enum parse_opt_result usage_with_options_internal(struct parse_opt_ctx_t > if (!err && ctx && ctx->flags & PARSE_OPT_SHELL_EVAL) > fputs("EOF\n", outfile); > > - return PARSE_OPT_HELP; > + return err ? PARSE_OPT_HELP_ERROR : PARSE_OPT_HELP; > } And the above matches this part, of course.