From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 03 Nov 2026 20:38:53 GMT
Subject: Re: Interaction between pre-commit hook and git commit <pathspec>
Message-ID: <xmqqmrrp646a.fsf@gitster.g>
In-Reply-To: <de4f4f35-500f-4d82-acfd-ca601444f2d2@app.fastmail.com>

"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:

> Reading githooks documentation for pre-commit. To me it reads like
> the use case is validation/checking, not any mutation.

Yes, the hook was written exactly for validation, to preempt an
undesirable commit from being created.

We might want to do two things:

(1) clarify the documentation to say that the hook should not try
    mutation, and

(2) detect and error out when the hook does try to make any
    mutation.

I am not sure if (2) is feasible, though.

Thanks.