From: Junio C Hamano Date: Tue, 17 Nov 2026 01:37:51 GMT Subject: Re: [PATCH v4 09/12] builtin/rerere: turn "diff" into a proper subcommand Message-ID: In-Reply-To: <20261111-pks-rerere-subcommands-v4-9-df0c8bf79e16@pks.im> Patrick Steinhardt writes: > +static int cmd_rerere_diff(int argc, > + const char **argv, > + const char *prefix, > + struct repository *repo) > +{ > + struct option options[] = { > + OPT_END(), > + }; > + struct string_list merge_rr = STRING_LIST_INIT_DUP; > + struct strbuf buf = STRBUF_INIT; > + struct rerere_cache cache; > + > + argc = parse_options(argc, argv, prefix, options, rerere_usage, 0); > + if (argc) > + usage(_("too many arguments")); We will make a mental note that "rerere diff" does not take any extra arguments. This matters when we look at the documentation patch later.