From: Junio C Hamano Date: Thu, 23 Jan 2014 18:02:46 GMT Subject: Re: [PATCH v2] Makefile: Fix compilation of Windows resource file Message-ID: In-Reply-To: Pat Thoyts writes: >>> GIT_VERSION=1.9.rc0 >>> all: >>> echo $(join -DMAJOR= -DMINOR= -DPATCH=, \ >>> $(wordlist 1,3,$(filter-out rc%,$(subst -, ,$(subst ., >>> ,$(GIT_VERSION)))) 0 0)) >>> >>> This removes any rc* parts and appends a couple of zeros so that all >>> missing elements should appear as 0 in the final list. >> >> As Junio already pointed out, this records the wrong number in the 1.9 >> track before 1.9.1 is out because the third position is the commit count, >> not the patch level. >> >> -- Hannes > > OK - I cehcked and you are right in that the GIT_VERSION value is the > one showing up the properties dialog at least under Windows 7. As this > is the most likely to be examined I agree that just taking the first > two digits is the simplest fix here. So, fine by me then. > > Acked-by: Pat Thoyts Thanks. -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.