From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 12 Jun 2015 19:38:40 GMT
Subject: Re: [PATCH v7 11/12] for-each-ref: introduce filter_refs()
Message-ID: <xmqqlhfod8e7.fsf@gitster.dls.corp.google.com>
In-Reply-To: <vpq1thixjs3.fsf@anie.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> +	filter_refs(&array, FILTER_REFS_ALL | FILTER_REFS_INCLUDE_BROKEN, &filter);
>
> I think it is more common to have options at the end, so I'd write it as
>
> filter_refs(&array, &filter, FILTER_REFS_ALL | FILTER_REFS_INCLUDE_BROKEN);
>
> (changing the declaration too, obviously)

Good point.

>
> I really like the way cmd_for_each_ref looks like now.

Likewise.