From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 07 Aug 2015 20:17:02 GMT
Subject: Re: [PATCH] submodule: implement `module_name` as a builtin helper
Message-ID: <xmqqlhdmyhtt.fsf@gitster.dls.corp.google.com>
In-Reply-To: <55C3BA5C.3030404@web.de>

Jens Lehmann <Jens.Lehmann@web.de> writes:

This change...

>> @@ -723,10 +733,8 @@ int fetch_populated_submodules(const struct argv_array *options,
>>   		if (!S_ISGITLINK(ce->ce_mode))
>>   			continue;
>>
>> -		name = ce->name;
>> -		name_for_path = unsorted_string_list_lookup(&config_name_for_path, ce->name);
>> -		if (name_for_path)
>> -			name = name_for_path->util;
>> +		name_for_path = submodule_name_for_path(ce->name);
>> +		name =  name_for_path ? name_for_path : ce->name;

... interacts with Heiko's cached submodule config work that seems
to have stalled.

I can discard the stalled topic and queue this one instead, asking
Heiko to reroll his on top once this has stabilized, or if Stefan is
really into revamping submodule now (which I hope is the case),
perhaps Heiko's work can be rerolled by Stefan (with help from
others, of course) as a prerequisite and then these changes can be
built on top of it?