From: Junio C Hamano Date: Thu, 07 Jul 2016 21:53:32 GMT Subject: Re: [PATCH 1/4] push options: {pre,post}-receive hook learns about push options Message-ID: In-Reply-To: Stefan Beller writes: > But your first patch (2/4) would not yet advertise the capability? > Or advertise and then just ignoring it? As I wrote... >> If I were doing this series, I >> would probably have done 2/4 first without plumbing it through >> (i.e. it is sent and accumulated in a string list at the receiver, >> and then cleared and freed without being used), and then added the >> processing (i.e. this step) as the second patch. ... I would imagine it would advertise, allow the other side to send, receive and collect, and then discard (properly) without using. > It is better for documentation purposes in this patch though. It makes > the other patch harder as "it allows transmitting push options, but > in that patch nothing of value is done with them." > > So I'll see if I can reorder easily. It does not matter too much. Let's not spend too much time on the ordering.