From: Junio C Hamano Date: Tue, 13 Sep 2016 23:06:10 GMT Subject: Re: [RFC/PATCH 16/17] diff: buffer output in emit_line_0 Message-ID: In-Reply-To: <20160913044613.1037-17-sbeller@google.com> Stefan Beller writes: > +struct line_emission { > + const char *set; > + const char *line; > + const char *ws; > + const char *reset; > + int first; > + int len; > + int whitespace_check; > + unsigned ws_rule; > + int has_trailing_carriage_return; > + int has_trailing_newline; > +}; It is somewhat strange to see whitespace things are per-line here. I'd understand it if it were per-path, though.