From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 23 Nov 2016 17:34:35 GMT
Subject: Re: [PATCH v1 15/19] config: add git_config_get_date_string() from gc.c
Message-ID: <xmqqlgwam76c.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAP8UFD0iToVxU+maNL9BFXacp3sER+AfrqAnQXWf7EAwURKmdQ@mail.gmail.com>

Christian Couder <christian.couder@gmail.com> writes:

> Ok it will appear like this in cache.h:
>
> /* This dies if the configured or default date is in the future */
> extern int git_config_get_expire_date_string(const char *key, const
> char **output);

Those who imitate existing callsites never read comments, and you
need to spend effort to get the name right to protect the codebase
from them.

"get-expiry" may be shorter.  Neither still does not say it will
die, though.