From: Junio C Hamano Date: Wed, 22 Mar 2017 22:38:59 GMT Subject: Re: [PATCH 3/3] t7004, t7030: fix here-doc syntax errors Message-ID: In-Reply-To: <20170322222230.yqqv6x4gokvb4jbz@sigill.intra.peff.net> Jeff King writes: > I worked up the patch to do that (see below), but I got stumped trying > to write the commit message. Perhaps that is what the test intended, but > I don't think tag's --format understands "%G" codes at all. > So you cannot tell from the output if a tag was valid or not; you have to check > the exit code separately. Thanks for digging; that was an unexpected show-stopper to me X-<. > you cannot tell at all which ones are bogus. Whereas with the current > behavior, the bogus ones are quietly omitted. Which can also be > confusing, but I'd think would generally err on the side of caution. OK.