From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 01 Apr 2017 02:29:42 GMT
Subject: Re: [PATCH] [GSOC] prune_worktrees(): reimplement with dir_iterator
Message-ID: <xmqqlgrkx3l5.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1491009687-10419-1-git-send-email-robert.stanca7@gmail.com>

Robert Stanca <robert.stanca7@gmail.com> writes:

> Replaces recursive traversing of opendir with dir_iterator

The original code for this one, and also the other one, is not
recursive traversing.  This one enumerates all the _direct_
subdirectories of ".git/worktrees", and feeds them to
prune_worktree() without recursing.  The other one scans all the
files _directly_ underneath ".git/objects/pack" to find the ones
that begin with the packtmp prefix, and unlinks them without
recursing.  Neither of them touches anything in subdirectory of
".git/worktrees/" nor ".git/objects/pack/".

Using dir_iterator() to make it recursive is not just overkill but
is a positively wrong change, isn't it?